Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some strange commas #385

merged 1 commit into from Mar 21, 2019


Copy link

I found some strange commas and removed them.

Copy link

Coverage Status

Coverage remained the same at 95.372% when pulling afb1b79 on mihyaeru21:remove-commas into d07b13a on rubyzip:master.

Copy link

@jdleesmiller jdleesmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also see no particular reason to have these commas, and I see no harm in removing them, because they are in comments.

I'm helping Alex with maintenance now, so I'll get this merged.

@jdleesmiller jdleesmiller merged commit bb34887 into rubyzip:master Mar 21, 2019
@mihyaeru21 mihyaeru21 deleted the remove-commas branch May 14, 2019 15:05
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants