Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump supported ruby versions #406

Merged
merged 1 commit into from Sep 25, 2019
Merged

Bump supported ruby versions #406

merged 1 commit into from Sep 25, 2019

Conversation

jdleesmiller
Copy link
Member

@jdleesmiller jdleesmiller commented Sep 18, 2019

Upgrade minimum supported ruby versions to include only supported rubies. This is planned as part of an upcoming major release (2.0).

This will hopefully make CI less fragile, allow us to upgrade our linting system, and allow us to take advantage of newer ruby features.

Fixes #404 .

Users who need older versions of ruby will still be able to use the planned 1.3 release for now.

I have tried to update the README and gemspec to make this clearer (and will update the changelog as part of the next release), to avoid confusion like in #254 .

Edit: I will leave this open for approximately one week for comment.

CC @hainesr @simonoff

@hainesr
Copy link
Member

hainesr commented Sep 20, 2019

Could we leave a couple of EOL rubies in the "allow failures" section of the CI?

Also, this PR will bump the rubyzip version to 2.0.0, per Semantic Versioning, so should this be included too? Or is it OK to do separately?

Otherwise, great.

@jdleesmiller
Copy link
Member Author

jdleesmiller commented Sep 20, 2019

Thanks for the feedback!

Could we leave a couple of EOL rubies in the "allow failures" section of the CI?

I like that idea, but it seems that setting the 2.4 version constraint in the gemspec prevents it from running on older rubies:

    rubyzip was resolved to 1.2.4, which depends on
      ruby (>= 2.4)

I don't know of any straightforward way around that.

Or is it OK to do separately?

I'm planning to bump the version number separately, after merging the outstanding PRs. I think that will be OK.

@hainesr
Copy link
Member

hainesr commented Sep 21, 2019

Good point about the versions - I obviously had my brain turned off at that point!

Yes, the only solution is to not test the older ones. That's fine. 👍

@jdleesmiller jdleesmiller merged commit e1d9af6 into master Sep 25, 2019
3 checks passed
@jdleesmiller jdleesmiller deleted the bump-supported-ruby branch Sep 25, 2019
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants