Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print library warnings to stderr with warn (not puts). #416

Merged
merged 3 commits into from Oct 19, 2019

Conversation

hainesr
Copy link
Member

@hainesr hainesr commented Oct 13, 2019

This has the advantage of consistency and being able to turn them off with, e.g. -W0.

Also, make the messages themselves more consistent and check that they are actually output.

(@jdleesmiller I mentioned a while back in another PR that I would work this one up.)

hainesr added 3 commits Oct 11, 2019
`warn` has the advantage of easily being disabled by, the `-W0` interpreter
flag or setting $VERBOSE to nil.
And fix a few spelling mistakes.
Check that they say the right things and are on stderr, not stdout. A
nice side effect of this is that it cleans up the test output.
@coveralls
Copy link

coveralls commented Oct 13, 2019

Coverage Status

Coverage remained the same at ?% when pulling ccabd94 on hainesr:warnings into 34d2074 on rubyzip:master.

Copy link
Member

@jdleesmiller jdleesmiller left a comment

Thanks, nice cleanup. 👍

@jdleesmiller jdleesmiller merged commit 15a54b4 into rubyzip:master Oct 19, 2019
1 check passed
@hainesr hainesr deleted the warnings branch Oct 19, 2019
jdleesmiller added a commit that referenced this pull request Oct 19, 2019
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants