Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options parameter to Zip::File.open. #418

Merged
merged 2 commits into from Oct 19, 2019

Conversation

hainesr
Copy link
Member

@hainesr hainesr commented Oct 19, 2019

I realized when working up #413 to fix #395 that this was missing, and would be much nicer to have than using Zip::File.new for most uses.

@coveralls
Copy link

coveralls commented Oct 19, 2019

Coverage Status

Coverage remained the same at 95.443% when pulling 3fea995 on hainesr:open-options into 34d2074 on rubyzip:master.

Copy link
Member

@jdleesmiller jdleesmiller left a comment

👍 Nice.

@jdleesmiller jdleesmiller merged commit 056c00c into rubyzip:master Oct 19, 2019
2 checks passed
@hainesr hainesr deleted the open-options branch Oct 19, 2019
jdleesmiller added a commit that referenced this pull request Oct 19, 2019
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants