Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing guide Improvement #331

Closed
vingar opened this issue Dec 12, 2017 · 0 comments
Closed

Contributing guide Improvement #331

vingar opened this issue Dec 12, 2017 · 0 comments
Assignees
@vingar
Labels
Documentation Release management
Milestone
1.14.6

Comments

@vingar
Copy link
Contributor

vingar commented Dec 12, 2017

Motivation

From the current contributing guide it's not clear that pull requests depending on their types should go against certain branches.
In addition, usual and popular pull request tools like the github interface and the hub wrapper are badly covered.

Modification

  • Few corrections for the format of the pull requests
  • Remind the logic for patch and feature pull requests
  • Mention the github interface and the equivalent workflow with hub
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
0be4802
@vingar vingar added this to the 1.14.3 milestone Dec 12, 2017
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
acbbc10
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
f06614c
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
d2cff9e
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
e798b7c
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
5e80302
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
fce3c82
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
bc704f8
vingar added a commit to vingar/rucio that referenced this issue Dec 12, 2017
@vingar
Contributing guide Improvement Fix rucio#331
05c2da0
@bari12 bari12 closed this as completed in ca408b4 Dec 13, 2017
bari12 added a commit that referenced this issue Dec 13, 2017
@bari12
Merge pull request #332 from vingar/patch-331-Contributing_guide_Impr…
c6f81b1 
…ovement

Contributing guide Improvement  Fix #331
bari12 added a commit that referenced this issue Dec 13, 2017
@bari12
Merge pull request #333 from vingar/patch-331-Contributing_guide_Impr…
c96a84b 
…ovement

Contributing guide Improvement  Fix #331
vingar added a commit to vingar/rucio that referenced this issue Dec 15, 2017
@vingar
Contributing guide Improvement Fix rucio#331
bf68242
yuyiguo pushed a commit to yuyiguo/rucio that referenced this issue Sep 20, 2023
@ericvaandering
Merge pull request rucio#331 from ericvaandering/1_29_images
415f732 
Get consistency checking ready for Igor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vingar vingar

Labels
Documentation Release management
Projects
None yet
Milestone
1.14.6
Development

No branches or pull requests
1 participant
@vingar