Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client migration to Python3 #819

Closed
10 tasks done
jwackito opened this issue Mar 6, 2018 · 4 comments
Closed
10 tasks done

Client migration to Python3 #819

jwackito opened this issue Mar 6, 2018 · 4 comments
Assignees
@jwackito @hahahannes
Labels
Clients enhancement patch
Milestone
1.18.7-clients

Comments

@jwackito
Copy link
Contributor

jwackito commented Mar 6, 2018 •
edited by bari12

Motivation

We need to make Rucio clients Python3 compatible

Modification

Proposed incremental scenario (each step should be one or several pull requests):

  • Enable 2to3 in travis to report py3k incompatibility
  • change print by print()
  • change xrange -> range
  • Fix dict.keys()/dict.values() to list()
  • Fixed exception to be py3K compatible
  • compatible imports
  • float, Long, etc
  • Unicode vs byte string
  • having a py3K packaging +ping test in the test suite for the clients once the migration is complete (e.g. tox)
  • Check compatibility with different Python 3 versions; Currently works with 3.5 but not with 3.6

others maybe, python3 interpreter will tell...
@jwackito jwackito self-assigned this Mar 6, 2018
@bari12
Copy link
Member

bari12 commented Mar 6, 2018

There is a general ticket tracking the py3k migration.
#67
You can use this for general tracking.

@bari12 bari12 mentioned this issue Mar 7, 2018
Closed
5 tasks
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: print to print() migration rucio#819
4c65fb2
@kreczko
Copy link
Contributor

kreczko commented Mar 7, 2018

BTW: I found that the six python module makes these kinds of things easier during the transition period:
https://pythonhosted.org/six/#module-six.moves

It is also easier to find them later (searching for six) whenever the project is ready to go Python 3 only.

jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: print to print() migration rucio#819
260638f 
Fixed for python2.6 (implicit __future__ import)
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: print to print() migration rucio#819
350c9a9 
Fixed for python2.6 (implicit __future__ import)
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: xrange to range rucio#819
83d77d1 
* 2to3 just replace the xrange by range. This could have some impact in
* the perfomance in long list for python 2.6. Yet the only replacement
* was in bin/rucio in a retry list, I bet this one is not that a big
* list.
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: xrange to range in rucio/client rucio#819
303559e
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: xrange to range in rucio/common rucio#819
2adabdf
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: xrange to range in rucio/rse (protocols) rucio#819
79bef70
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: xrange to range in rucio/tests rucio#819
c47c5b8
This was referenced Mar 7, 2018
Merged
Merged
jwackito added a commit to jwackito/rucio that referenced this issue Mar 7, 2018
@jwackito
Clients: print to print() in rucio/client rucio#819
18a6127
This was referenced Mar 7, 2018
Merged
Merged
@bari12 bari12 modified the milestones: 1.16.4-clients, 1.16.5-clients, 1.17.0-clients, 1.17.1-clients Jun 15, 2018
@bari12 bari12 modified the milestones: 1.17.1-clients, 1.17.2-clients Jun 25, 2018
@bari12 bari12 modified the milestones: 1.17.5-clients, 1.17.6-clients Jul 23, 2018
@bari12 bari12 modified the milestones: 1.17.6-clients, 1.17.7-clients Aug 6, 2018
@bari12 bari12 added Overview Used for overview issues, linking to other issues and removed Overview Used for overview issues, linking to other issues labels Aug 9, 2018
@bari12 bari12 mentioned this issue Aug 21, 2018
Closed
@cserf
Copy link
Contributor

cserf commented Dec 6, 2018

I think all the client files are now py3k compatible. @hahahannes can you confirm ?

@hahahannes
Copy link
Contributor

hahahannes commented Dec 6, 2018 •
edited

The last ones missing are the didclient, fileclient, dq2client and the downloadclient. According to pylint there are just small changes needed. I can fix them.

@hahahannes hahahannes mentioned this issue Dec 6, 2018
Closed
@bari12 bari12 assigned jwackito and hahahannes and unassigned jwackito Dec 7, 2018
@bari12 bari12 added this to the 1.18.7-clients milestone Dec 7, 2018
@bari12 bari12 closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwackito jwackito

@hahahannes hahahannes

Labels
Clients enhancement patch
Projects
None yet
Milestone
1.18.7-clients
Development

No branches or pull requests
5 participants
@jwackito @bari12 @kreczko @cserf @hahahannes