Fix textlist alignments (update) #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Seems as if both X & Y co-ordinates need to be defined for "pos", "size", and minor adjustment to "selectOffsetY" - works in 1080p (haven't tested other resolution layouts)
- re-added listx and listWidth variables - update pos, size and selectorOffsetY
- update pos, size and selectorOffsetY to fix broken alignments
- update y size, y pos, and y offset
-duplicate pc.png for use with ScummVM
- duplicate pc background
- duplicate pc background
- duplicate pc background
- resolve floating point overflow
- resolve float overflow
- resolve float overflow
resolve float overflow
- resolve float overflow
-resolve float overflow
- resolve float overflow
- resolve float overflow
- selectorHeight & selectorOffsetY recalculations
- selectorHeight + selectorOffsetY recalculation
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 13, 2023
Added the ability to patch themes locally to fix layout bugs surfaced after EmulationStation's fixes for positioning added a while ago. Mostly done to fix @ruckage's themes, which haven't been updated in a long time. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, based on https://github.com/ruckage/es-theme-nes-mini/pulls, submittedf by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?) * for the 'famicom-mini' theme, adapted from the previous patch
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 13, 2023
Added the ability to patch themes locally to fix layout bugs surfaced after EmulationStation's fixes for positioning added a while ago. Mostly done to fix @ruckage's themes, which haven't been updated in a long time. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, based on https://github.com/ruckage/es-theme-nes-mini/pulls, submittedf by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?) * for the 'famicom-mini' theme, adapted from the previous patch
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 13, 2023
Added the ability to patch themes locally to fix layout bugs surfaced after EmulationStation's fixes for positioning added a while ago. Mostly done to fix @ruckage's themes, which haven't been updated in a long time. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, based on https://github.com/ruckage/es-theme-nes-mini/pulls, submittedf by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?) * for the 'famicom-mini' theme, adapted from the previous patch
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 22, 2023
Added the ability to patch themes locally to fix layout bugs surfaced after EmulationStation's fixes for positioning added a while ago. Mostly done to fix @ruckage's themes, which haven't been updated in a long time. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, started from https://github.com/ruckage/es-theme-nes-mini/pulls/13, submittedf by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?). Followed by some testing and fixing for the other resolutions which are not covered by the initial changes. * for the 'famicom-mini' theme, adapted from the previous patch with adjustments added
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 23, 2023
Added the ability to patch themes locally to fix layout bugs surfaced after EmulationStation's fixes for positioning added a while ago. Mostly done to fix @ruckage's themes, which haven't been updated in a long time. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, started from https://github.com/ruckage/es-theme-nes-mini/pulls/13, submittedf by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?). Followed by some testing and fixing for the other resolutions which are not covered by the initial changes. * for the 'famicom-mini' theme, adapted from the previous patch with adjustments added
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 23, 2023
Added the ability to patch themes locally to fix the gamelist layout bugs in themes, surfaced after EmulationStation's fixes for positioning, added a in 2.10.x. Mostly done to fix @ruckage's themes, which haven't been updated after the new EmulationStation version. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, started from https://github.com/ruckage/es-theme-nes-mini/pulls/13, submitted by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?). Followed by some testing and fixing for the other resolutions which are not covered by the initial changes. * for the 'famicom-mini' theme, adapted from the previous patch with some adjustments added after testing each resolution supported.
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
Nov 24, 2023
Added the ability to patch themes locally to fix the gamelist layout bugs in themes, surfaced after EmulationStation's fixes for positioning, added a in 2.10.x. Mostly done to fix @ruckage's themes, which haven't been updated after the new EmulationStation version. Fixes included: * for the 'snes-mini' theme, based on ruckage/es-theme-snes-mini#26, submitted by @makofee * for the 'nes-mini' theme, started from https://github.com/ruckage/es-theme-nes-mini/pulls/13, submitted by @grosa1, which in turn is based on https://retropie.org.uk/forum/topic/12583/snes-mini-theme/929?_=1699852993853 (?). Followed by some testing and fixing for the other resolutions which are not covered by the initial changes. * for the 'famicom-mini' theme, adapted from the previous patch with some adjustments added after testing each resolution supported.
Update offsets for ntsc display
d0dders
added a commit
to d0dders/es-theme-snes-mini
that referenced
this pull request
Sep 14, 2024
Text alignment fixes from ruckage#26
|
The offsets applied to NTSC can also be applied to PAL |
bulzipke
added a commit
to bulzipke/es-theme-snes-mini
that referenced
this pull request
Nov 28, 2024
Text alignment fixes from ruckage#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust y pos, y size, and y selectorOffsets for all resolutions
corrected offset values to calculate whole number outputs
possible fix for crashing ES