From 1d9320d0bc2d40bea78eea8d485de90f4ea39609 Mon Sep 17 00:00:00 2001 From: Pavan Chaithanya <74360974+BonapartePC@users.noreply.github.com> Date: Thu, 12 Jan 2023 00:14:49 +0530 Subject: [PATCH] chore: add logs when backup is skipped due to preferences (#2867) --- jobsdb/backup.go | 3 ++- processor/stash/stash.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/jobsdb/backup.go b/jobsdb/backup.go index a4d6cfab3e..ca90c9607b 100644 --- a/jobsdb/backup.go +++ b/jobsdb/backup.go @@ -522,6 +522,7 @@ func (jd *HandleT) createTableDumps(queryFunc func(int64) string, pathFunc func( } if !preferences.Backup(jd.tablePrefix) { offset++ + jd.logger.Infof("Skipping backup for workspace: %s. Preferences: %v and tablePrefix: %s", workspaceID, preferences, jd.tablePrefix) continue } rawJSONRows = append(rawJSONRows, '\n') // appending '\n' @@ -585,7 +586,7 @@ func (jd *HandleT) uploadTableDump(ctx context.Context, workspaceID, path string jd.logger.Errorf("[JobsDB] :: Failed to upload table dump for workspaceId %s. Error: %s", workspaceID, err.Error()) return err } - jd.logger.Infof("[JobsDB] :: Backed up table at %v", output.Location) + jd.logger.Infof("[JobsDB] :: Backed up table at %s for workspaceId %s", output.Location, workspaceID) fileUploadTimeStat.End() return nil } diff --git a/processor/stash/stash.go b/processor/stash/stash.go index 64843e39a5..d11fe0eaa5 100644 --- a/processor/stash/stash.go +++ b/processor/stash/stash.go @@ -230,6 +230,7 @@ func (st *HandleT) storeErrorsToObjectStorage(jobs []*jobsdb.JobT) (errorJob []E } prefixes := []string{"rudder-proc-err-logs", time.Now().Format("01-02-2006")} uploadOutput, err := errFileUploader.Upload(context.TODO(), outputFile, prefixes...) + st.logger.Infof("Uploaded error logs to %s for workspaceId %s", uploadOutput.Location, wrkId) errorJobs = append(errorJobs, ErrorJob{ jobs: jobsPerWorkspace[wrkId], errorOutput: StoreErrorOutputT{