Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(destination): onboarding Lambda destination #2229

Merged
merged 19 commits into from Aug 16, 2022
Merged

feat(destination): onboarding Lambda destination #2229

merged 19 commits into from Aug 16, 2022

Conversation

sandeepdsvs
Copy link
Contributor

Description

Added support for new custom destination AWS Lambda

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
services/streammanager/lambda/lambdamanager.go Outdated Show resolved Hide resolved
@sandeepdsvs sandeepdsvs changed the title feat(new integration): Onboarding Lambda destination feat(destination): Onboarding Lambda destination Aug 5, 2022
@sandeepdsvs sandeepdsvs changed the title feat(destination): Onboarding Lambda destination feat(destination): onboarding Lambda destination Aug 5, 2022
@sandeepdsvs sandeepdsvs self-assigned this Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2229 (c8b4bfa) into master (e8dcd87) will increase coverage by 0.14%.
The diff coverage is 47.56%.

@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
+ Coverage   33.19%   33.33%   +0.14%     
==========================================
  Files         193      194       +1     
  Lines       38635    38718      +83     
==========================================
+ Hits        12825    12907      +82     
+ Misses      25013    25002      -11     
- Partials      797      809      +12     
Impacted Files Coverage Δ
services/streammanager/streammanager.go 0.00% <0.00%> (ø)
warehouse/azure-synapse/azure-synapse.go 0.47% <0.00%> (-0.01%) ⬇️
warehouse/bigquery/bigquery.go 0.00% <0.00%> (ø)
warehouse/clickhouse/clickhouse.go 0.00% <0.00%> (ø)
warehouse/deltalake/deltalake.go 0.00% <0.00%> (ø)
warehouse/mssql/mssql.go 0.46% <0.00%> (-0.01%) ⬇️
warehouse/postgres/postgres.go 0.00% <0.00%> (ø)
warehouse/redshift/redshift.go 0.00% <0.00%> (ø)
warehouse/snowflake/snowflake.go 0.00% <0.00%> (ø)
warehouse/utils/utils.go 60.12% <0.00%> (-1.43%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lvrach lvrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. I only have one concern regarding the performance of gjson since it will run on a critical path.

I suggested a small change and usage of fastjson.

@cisse21 cisse21 merged commit 581aef4 into master Aug 16, 2022
@cisse21 cisse21 deleted the feat.lambda branch August 16, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants