From 883820c7656a11fa416329f7101176c25350b14d Mon Sep 17 00:00:00 2001 From: rudxDe Date: Fri, 22 Jul 2022 09:55:54 +0200 Subject: [PATCH] fix(*): add workdir /app to each base dockerfile #866 --- README.md | 1 + packages/init/templates/Dockerfile.base | 1 + .../lerna-dockerize/test/integration/config-file/Dockerfile.base | 1 + .../test/integration/config-file/Dockerfile.expected | 1 + .../test/integration/custom_dockerfile/Dockerfile.base | 1 + .../test/integration/custom_dockerfile/Dockerfile.expected | 1 + packages/lerna-dockerize/test/integration/hoist/Dockerfile.base | 1 + .../lerna-dockerize/test/integration/hoist/Dockerfile.expected | 1 + .../lerna-dockerize/test/integration/if_exists/Dockerfile.base | 1 + .../test/integration/if_exists/Dockerfile.expected | 1 + .../lerna-dockerize/test/integration/npm_i_args/Dockerfile.base | 1 + .../test/integration/npm_i_args/Dockerfile.expected | 1 + .../lerna-dockerize/test/integration/pre-stage/Dockerfile.base | 1 + .../test/integration/pre-stage/Dockerfile.expected | 1 + packages/lerna-dockerize/test/integration/simple/Dockerfile.base | 1 + .../lerna-dockerize/test/integration/simple/Dockerfile.expected | 1 + .../test/integration/split-stages/Dockerfile.base | 1 + .../test/integration/split-stages/Dockerfile.expected | 1 + 18 files changed, 18 insertions(+) diff --git a/README.md b/README.md index dc7af095..568bebbd 100644 --- a/README.md +++ b/README.md @@ -44,6 +44,7 @@ Create the file `Dockerfile.base` in your projects root and add the following co ``` FROM node:14 as base +WORKDIR /app COPY ./package.json ./ RUN npm i COPY ./lerna.json ./ diff --git a/packages/init/templates/Dockerfile.base b/packages/init/templates/Dockerfile.base index 581cc337..84d5efc5 100644 --- a/packages/init/templates/Dockerfile.base +++ b/packages/init/templates/Dockerfile.base @@ -1,6 +1,7 @@ # This is the base dockerfile. Here the base image is pulled and the ras setup is done for the project. # Make sure to include the base setup for lerna here. FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install COPY ./lerna.json ./ diff --git a/packages/lerna-dockerize/test/integration/config-file/Dockerfile.base b/packages/lerna-dockerize/test/integration/config-file/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/config-file/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/config-file/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/config-file/Dockerfile.expected b/packages/lerna-dockerize/test/integration/config-file/Dockerfile.expected index ebeb4360..ffd0a7ee 100644 --- a/packages/lerna-dockerize/test/integration/config-file/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/config-file/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.base b/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.expected b/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.expected index 2d2b548c..9ac0e30e 100644 --- a/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/custom_dockerfile/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/hoist/Dockerfile.base b/packages/lerna-dockerize/test/integration/hoist/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/hoist/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/hoist/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/hoist/Dockerfile.expected b/packages/lerna-dockerize/test/integration/hoist/Dockerfile.expected index db8bc107..5dbede0f 100644 --- a/packages/lerna-dockerize/test/integration/hoist/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/hoist/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.base b/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.expected b/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.expected index a01c0fab..ceabad11 100644 --- a/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/if_exists/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.base b/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.expected b/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.expected index 52111570..e708cc38 100644 --- a/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/npm_i_args/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.base b/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.base index 4d820a00..e70af244 100644 --- a/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.base @@ -1,4 +1,5 @@ ARG NODE_VERSION=16 FROM node:${NODE_VERSION} as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.expected b/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.expected index cbc989b7..90388f17 100644 --- a/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/pre-stage/Dockerfile.expected @@ -1,5 +1,6 @@ ARG NODE_VERSION=16 FROM node:${NODE_VERSION} as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/simple/Dockerfile.base b/packages/lerna-dockerize/test/integration/simple/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/simple/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/simple/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/simple/Dockerfile.expected b/packages/lerna-dockerize/test/integration/simple/Dockerfile.expected index ebeb4360..ffd0a7ee 100644 --- a/packages/lerna-dockerize/test/integration/simple/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/simple/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a diff --git a/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.base b/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.base index f52d2d08..fbe9e58e 100644 --- a/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.base +++ b/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.base @@ -1,3 +1,4 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install diff --git a/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.expected b/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.expected index 7dba6a53..fd348b74 100644 --- a/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.expected +++ b/packages/lerna-dockerize/test/integration/split-stages/Dockerfile.expected @@ -1,4 +1,5 @@ FROM node:16 as base +WORKDIR /app COPY ./package.json ./ RUN npm install # Package a