Skip to content

Alexey Kinev
rudyryk

Organizations

@05bit
rudyryk commented on issue 05bit/peewee-async#15
@rudyryk

Async layer is responsible for executing queries. Considering that, I'd think of adding get_related() function in addition to get_object(). Or ma…

rudyryk commented on issue 05bit/peewee-async#15
@rudyryk

Here starts mixing of concepts, which I strongly would like to avoid. To be clear: peewee layer is responsible for constructing queries. Async laye…

rudyryk commented on issue 05bit/peewee-async#15
@rudyryk

I doubt we need a special interface for that, at this time we may just join related fields with main query. This is actually preferred practice for…

rudyryk commented on pull request 05bit/peewee-async#17
@rudyryk

@mrbox Thank you Jakub! I'll take a look and merge tomorrow, hope everything will be fine :) Deferred init is a new feature as I can see, before th…

@rudyryk
rudyryk merged pull request 05bit/peewee-async#16
@rudyryk
Asynchronous version of prefetch method
2 commits with 113 additions and 7 deletions
@rudyryk
Add support for prefetch() new peewee feature
rudyryk commented on pull request 05bit/peewee-async#16
@rudyryk

@cypreess Transactions are half-working actually - not working with connection pool #14

rudyryk commented on pull request 05bit/peewee-async#16
@rudyryk

Hi @cypreess! Thanks you, that's great! I think we need to add a test case wrapped in sync_unwanted() context just to make sure there are no implic…

@rudyryk

Oh, that's my dream too! :+1:

rudyryk commented on issue 05bit/peewee-async#14
@rudyryk

If I understand the problem clearly, we pick a cursor for every request, but we should reuse one cursor per transaction.

@rudyryk
Transactions support
rudyryk commented on issue 05bit/peewee-async#12
@rudyryk

Closing this issue. Created separate one for bug with connection pool #14

@rudyryk
Transactions are broken with connections pool
rudyryk commented on issue 05bit/peewee-async#12
@rudyryk

@mrbox Jakub, thank you for contribution! I've refactored tests to have a single entry point, renamed database methods to have _async() part as suf…

@rudyryk
@rudyryk
  • @rudyryk 78f6f4f
    Extract tests to package with conditional extra tests import for Pyth…
@rudyryk
rudyryk merged pull request 05bit/peewee-async#13
@rudyryk
raw queries and async transactions
2 commits with 331 additions and 8 deletions
@rudyryk

because it's called from _atomic context manager(with db.atomic()) Oh, ok then! :) I meant not methods of class but module functions, e.g. peewe…

rudyryk commented on pull request 05bit/peewee-async#13
@rudyryk

@mrbox Great! :) Thank you!

@rudyryk

it'll blow up because Peewee will expect it to be normal Hmm... That's possible, but why it would? I haven't done investigation yet, so I have no…

Something went wrong with that request. Please try again.