New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore and whitespace #3

Merged
merged 3 commits into from Jan 30, 2015

Conversation

Projects
None yet
2 participants
@spacebat
Contributor

spacebat commented Jan 21, 2015

Hi, I'm participating in the CPAN PR Challenge and was assigned your module.

I noticed that some build artefacts showed up in git status, and that there was some mixed usage of tabs and spaces. I've also created a simple test for the core functionality of the module. I hope you find this PR useful.

Cheers

spacebat added some commits Jan 21, 2015

add test for create_distro
BUILD_REQUIRES is introduced to the Makefile and Test::TempDir::Tiny is
added so that the new test file can easily create and require a simple
module, then add another and require that.
@rueycheng

This comment has been minimized.

Show comment
Hide comment
@rueycheng

rueycheng Jan 30, 2015

Owner

Cool. My apologies for the delay in replying. The PR looks quite decent; I'll have a look later and see what I can do about it.

Owner

rueycheng commented Jan 30, 2015

Cool. My apologies for the delay in replying. The PR looks quite decent; I'll have a look later and see what I can do about it.

rueycheng added a commit that referenced this pull request Jan 30, 2015

Merge pull request #3 from spacebat/master
amendments for improving code readability

@rueycheng rueycheng merged commit 0b8ca00 into rueycheng:master Jan 30, 2015

@rueycheng

This comment has been minimized.

Show comment
Hide comment
@rueycheng

rueycheng Jan 30, 2015

Owner

Just uploaded it to PAUSE. Cheers.

Owner

rueycheng commented Jan 30, 2015

Just uploaded it to PAUSE. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment