New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license and min perl version and new test #5

Merged
merged 2 commits into from Nov 24, 2017

Conversation

Projects
None yet
2 participants
@lharey
Contributor

lharey commented Nov 24, 2017

Hi,

I was given your module as part of the PR Pull request challenge.

This adds the license and min perl version to the MakeFile to resolve the 2 'extra issues' cpants warnings (https://cpants.cpanauthors.org/dist/Module-Starter-Smart).

I have also ran test coverage against the repo and found that the 'create_Build_PL' function did not have a test. Therefore I have added a test for this.

Regards
Lisa

@rueycheng

Looks good, thanks.

@rueycheng rueycheng merged commit 4236e37 into rueycheng:master Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment