web: Add ruffle() (Version 1) API
#17939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
added
A-web
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
Dinnerbone
commented
Sep 15, 2024
evilpie
reviewed
Sep 21, 2024
Contributor
Author
|
I've gone ahead and changed |
Dinnerbone
force-pushed
the
v1
branch
2 times, most recently
from
6ff7d0d to
875e781
Compare
Contributor
Author
|
Renamed |
Contributor
Author
|
Changed |
This comment was marked as outdated.
This comment was marked as outdated.
Dinnerbone
force-pushed
the
v1
branch
2 times, most recently
from
0231cea to
b02a20d
Compare
adrian17
approved these changes
Nov 16, 2024
At this commit, the V1 API is identical to Legacy API
PrivateGER
pushed a commit
to PrivateGER/Sharkey
that referenced
this pull request
Dec 9, 2024
These can be replaced later when Ruffle API v1 releases with proper TypeScript definitions and such: ruffle-rs/ruffle#17939 I am planning to do so myself when that happens. For now, Dinnerbone has graciously provided us with type definitions of the current API. Co-authored-by: Nathan Adams <dinnerbone@dinnerbone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bikeshedding time, here's the chance to decide what the "v1 api" looks like before we lock it in.
The only change so far is that I've added a specific method for calling EI, vs the very easy-to-break and implicit "the method will exist, trust me". I'm awaiting feedback before touching anything else.
Whilst this is "version 1" (
PlayerV1interface), if we never add a V2 that's totally fine.ruffle()is the same asruffle(1).Things to consider for each existing member of the API: