New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to enable https for AwsAuthV4 transport #1456

Closed
cfoehrdes opened this Issue Feb 9, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@cfoehrdes

cfoehrdes commented Feb 9, 2018

We are trying to use the AwsAuthV4 transport with ssl and are not able to pass the ssl option to it.

It seems that it is not possible because the ssl config param accessed in the AwsAuthV4 class (see https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Transport/AwsAuthV4.php#L77) is never set.
The keys of the config array are limited to bigintConversion, curl, headers and url in the client when preparing the transport configuration. (see https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Client.php#L162)

@cfoehrdes

This comment has been minimized.

cfoehrdes commented Feb 9, 2018

It could be an option to pass the ssl key to the config array or maybe we could also use getParam to fetch the ssl setting, as it is done with the access keys.

@ruflin

This comment has been minimized.

Owner

ruflin commented Feb 12, 2018

@cfoehrdes Feel free to open a PR for further discussions. This should make it more obvious what the changes required would be.

@cfoehrdes

This comment has been minimized.

cfoehrdes commented Feb 12, 2018

@ruflin The PR #1457 is pretty much what solves the problem

@ruflin

This comment has been minimized.

Owner

ruflin commented Feb 16, 2018

Closing as #1457 was merged.

@aderuwe

This comment has been minimized.

aderuwe commented Apr 25, 2018

@ruflin Seems to have been never closed. ;)

@ruflin

This comment has been minimized.

Owner

ruflin commented Apr 25, 2018

Ups, seems like I hit the wrong button. Thanks @aderuwe

@ruflin ruflin closed this Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment