-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass DSN to the Elastica\Client constructor #1640
Comments
Yes, this would be particular helpful on deployments like Heroku, which creates the DSN environment variable when the service is created, but configuring it requires manually breaking it apart into the individual components. |
Do you see a way how we could introduce this without making it a breaking change? In general, +1 on having such a feature. |
alamirault
added a commit
to alamirault/Elastica
that referenced
this issue
Aug 17, 2019
alamirault
added a commit
to alamirault/Elastica
that referenced
this issue
Aug 25, 2019
alamirault
added a commit
to alamirault/Elastica
that referenced
this issue
Aug 25, 2019
ruflin
pushed a commit
that referenced
this issue
Aug 28, 2019
PR is now merge, I think @ruflin you can close issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently I have to handle config options as separated keys in each environment my application is deployed (local, ci, staging, prod...). Things become hard when an environment required an option the other don't...
It could be cool if
Elastica\Client
's constructor becomes able to parse a single string.The text was updated successfully, but these errors were encountered: