New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms filter lookup should accept routing and cache params #579

Closed
MrHash opened this Issue Apr 5, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@ruflin

This comment has been minimized.

Owner

ruflin commented Apr 5, 2014

It looks like the first 4 are mandatory, the additional ones are optional one. So instead of extending, I would suggest to replace $index with $options = array(). And to make it BW compatible, in case it isn't an array, $index is picked. Like this also params can be added in the future without having to change the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment