Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
@olchick For me it seems like broke BC.
For now Elastica always sends retry_on_conflict=0 by default. With your PR it will be taken from elasticsearch configuration and it can be not 0, for such developers it will be broke BC.
More right make something like "unsetConfig('retry_on_conflict')" or "setConfig('retry_on_conflict', null)" and than client can omit it when perform request.
Also what with 'version' field from original issue? I think if Amazon care about "retry_on_conflict" it will be also raise errors for "version", and your PR solve only retry_on_conflict.
You said there is a configuration which can be changed and due that not sending the default value would be a BC break for those people.
So what configuration are you talking about?