Allow strings for setMinimumMatch in Terms query #1151

Merged
merged 2 commits into from Jul 31, 2016

Conversation

Projects
None yet
2 participants
@topikito
Contributor

topikito commented Jul 27, 2016

This closes #1149

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2016

Owner

LGTM. Can you also update the changelog?

Owner

ruflin commented Jul 27, 2016

LGTM. Can you also update the changelog?

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2016

Owner

I'm curious why Travis did not start on this PR?

Owner

ruflin commented Jul 27, 2016

I'm curious why Travis did not start on this PR?

@topikito

This comment has been minimized.

Show comment
Hide comment
@topikito

topikito Jul 27, 2016

Contributor

@ruflin Sure, will do

Contributor

topikito commented Jul 27, 2016

@ruflin Sure, will do

@topikito

This comment has been minimized.

Show comment
Hide comment
@topikito

topikito Jul 27, 2016

Contributor

@ruflin Done

Contributor

topikito commented Jul 27, 2016

@ruflin Done

@topikito

This comment has been minimized.

Show comment
Hide comment
@topikito

topikito Jul 27, 2016

Contributor

Seems like Travis is now willing to test the changelog

Contributor

topikito commented Jul 27, 2016

Seems like Travis is now willing to test the changelog

/**
* @group unit
+ * @dataProvider provideMinimumArguments

This comment has been minimized.

@ruflin

ruflin Jul 27, 2016

Owner

It would be nice to also have this for an integration test to make sure it also works with the current elasticsearch version. but we can add this in an other PR.

@ruflin

ruflin Jul 27, 2016

Owner

It would be nice to also have this for an integration test to make sure it also works with the current elasticsearch version. but we can add this in an other PR.

@ruflin ruflin merged commit 548b1d4 into ruflin:master Jul 31, 2016

2 checks passed

codecov/project 85.20% (+0.00%) compared to 62fafe0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 31, 2016

Owner

Merged. Thanks

Owner

ruflin commented Jul 31, 2016

Merged. Thanks

@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file based on the
### Bugfixes
- Set HTTP headers on each request preventing server error if persistent connection is enabled and compression enabled and later disabled for the same connection.
+- Removed `int` type hinting in `setMinimumMatch` (`Terms` Query): it should also allow `string`. [#1151](https://github.com/ruflin/Elastica/pull/1151)

This comment has been minimized.

@ruflin

ruflin Jul 31, 2016

Owner

I will probably move this to improvements before the next release as I don't think it was a "bug". The limitation was more for historical reasons.

@ruflin

ruflin Jul 31, 2016

Owner

I will probably move this to improvements before the next release as I don't think it was a "bug". The limitation was more for historical reasons.

This comment has been minimized.

@topikito

topikito Aug 1, 2016

Contributor

Sure - I just considered as a bug because the expected behaviour was not meeting the functional one.

@topikito

topikito Aug 1, 2016

Contributor

Sure - I just considered as a bug because the expected behaviour was not meeting the functional one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment