Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Optimize memory usage for Http Adapter #1161
Thanks for the PR to make the code faster. Can you please update the CHANGELOG.md file? Adding a test to confirm the optimization of this can is quite tricky, but it looks very reasonable :-)
One question that this raised on my side is, why do we have JSON_ELASTICSEARCH at all? I looks like we could replace it everywhere with JSON_UNESCAPED_UNICODE https://github.com/ruflin/Elastica/blob/master/lib/Elastica/JSON.php#L59 My assumption is we needed it for some historical reasons (PHP version compatibility).
The changed code is already covered by quite a few other integration tests I assume as it is such a central part. So I worry not too much that it breaks the code. No need to share the Backfire profile, the changes make a lot of sense. I fully trust you here :-)
In case you have an easy test to add feel free to add it, but not required. Only additional thing required is the update to the CHANGELOG.md