Update es test version to 5.2 #1245

Merged
merged 1 commit into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@ruflin
Owner

ruflin commented Feb 8, 2017

No description provided.

@ruflin ruflin referenced this pull request Feb 8, 2017

Merged

Finalize elasticsearch 5 migration #1242

7 of 7 tasks complete
@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB Mar 30, 2017

Contributor

@ruflin Any ETA on the next release? It would be nice to have a release containing 3e02937

Contributor

XWB commented Mar 30, 2017

@ruflin Any ETA on the next release? It would be nice to have a release containing 3e02937

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Mar 30, 2017

Owner

No ETA but definitively something I can push forward :-) Put it on my TODO list.

Owner

ruflin commented Mar 30, 2017

No ETA but definitively something I can push forward :-) Put it on my TODO list.

@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB Mar 30, 2017

Contributor

Put it on my TODO list.

Excellent :)

Contributor

XWB commented Mar 30, 2017

Put it on my TODO list.

Excellent :)

Update elasticsearch test version to 5.2
* Update elasticsearch-php dependency to 5.2
* Update incompatible test
* Update README page
* Update CHANGELOG

@ruflin ruflin merged commit 8b45039 into master Apr 13, 2017

@ruflin ruflin deleted the update-to-es520 branch Apr 13, 2017

@ruflin

This comment has been minimized.

Show comment
Hide comment
@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB Apr 21, 2017

Contributor

Yes, already installed :) Thanks!

Contributor

XWB commented Apr 21, 2017

Yes, already installed :) Thanks!

@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB May 24, 2017

Contributor

@ruflin

All FOSElasticaBundle resetter tests fail after upgrading Elastica to 5.2, any idea where I should start looking?

Contributor

XWB commented May 24, 2017

@ruflin

All FOSElasticaBundle resetter tests fail after upgrading Elastica to 5.2, any idea where I should start looking?

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin May 26, 2017

Owner

Could you share the CI error you get? What is resetter doing?

Owner

ruflin commented May 26, 2017

Could you share the CI error you get? What is resetter doing?

@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB May 27, 2017

Contributor

@ruflin

  1. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetAllIndexes
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  2. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndex
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  3. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentName
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  4. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentNameAndAlias
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  5. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetType
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

  6. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetTypeWithChangedSettings
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

Contributor

XWB commented May 27, 2017

@ruflin

  1. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetAllIndexes
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  2. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndex
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  3. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentName
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  4. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetIndexWithDifferentNameAndAlias
    Expectation failed for method name is equal to string:request when invoked 2 time(s).
    Method was expected to be called 2 times, actually called 0 times.

  5. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetType
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

  6. FOS\ElasticaBundle\Tests\Index\ResetterTest::testResetTypeWithChangedSettings
    Expectation failed for method name is equal to string:request when invoked 3 time(s).
    Method was expected to be called 3 times, actually called 0 times.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin May 29, 2017

Owner

Could this be related to #1277 ?

Owner

ruflin commented May 29, 2017

Could this be related to #1277 ?

@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB May 31, 2017

Contributor

I think so, but I have no clue where to start looking.

Contributor

XWB commented May 31, 2017

I think so, but I have no clue where to start looking.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jun 2, 2017

Owner

I think the problem is that you check for request calls but now requestEndpoint is called. TBH this kind of test is quite new to me :-)

Owner

ruflin commented Jun 2, 2017

I think the problem is that you check for request calls but now requestEndpoint is called. TBH this kind of test is quite new to me :-)

@XWB

This comment has been minimized.

Show comment
Hide comment
Contributor

XWB commented Jun 7, 2017

Found it, thanks :)

FriendsOfSymfony/FOSElasticaBundle@f434157

mhernik pushed a commit to mhernik/Elastica that referenced this pull request Jul 24, 2017

Update elasticsearch test version to 5.2 (#1245)
* Update elasticsearch-php dependency to 5.2
* Update incompatible test
* Update README page
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment