Fix AnalyzeAPI with 'explain' parameter #1254

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@thePanz
Contributor

thePanz commented Feb 20, 2017

The ElasticSearch AnalyzeAPI has an "explain" parameter to gather further details about the performed analysis on a text content.
Unfortunately the ElasticSearch response is different when such parameter is set or not set.
See https://www.elastic.co/guide/en/elasticsearch/reference/5.2/_explain_analyze.html
and https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html.

The format "explain = true" is consistent in the 5.x major release.

@Tobion

This comment has been minimized.

Show comment
Hide comment
@Tobion

Tobion Feb 20, 2017

Collaborator

👍 would be nice if you could add a note to the changelog file

Collaborator

Tobion commented Feb 20, 2017

👍 would be nice if you could add a note to the changelog file

@thePanz

This comment has been minimized.

Show comment
Hide comment
@thePanz

thePanz Feb 21, 2017

Contributor

@Tobion : Changelog added

Contributor

thePanz commented Feb 21, 2017

@Tobion : Changelog added

CHANGELOG.md
@@ -11,6 +11,8 @@ All notable changes to this project will be documented in this file based on the
### Improvements
+- added support for the "explain" flag of AnalyzeAPI

This comment has been minimized.

@ruflin

ruflin Feb 21, 2017

Owner

@thePanz Could you also add the PR number behind it? We missed it in the recent changelog entries but I want to add it again as it makes reading changelogs easier as you can jump to the PR directly.

@ruflin

ruflin Feb 21, 2017

Owner

@thePanz Could you also add the PR number behind it? We missed it in the recent changelog entries but I want to add it again as it makes reading changelogs easier as you can jump to the PR directly.

This comment has been minimized.

@thePanz

thePanz Feb 21, 2017

Contributor

@ruflin PR number and link added. Does it work OK for you?

@thePanz

thePanz Feb 21, 2017

Contributor

@ruflin PR number and link added. Does it work OK for you?

@ruflin

ruflin approved these changes Feb 21, 2017

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Feb 21, 2017

Owner

@thePanz LGTM. Thanks

Owner

ruflin commented Feb 21, 2017

@thePanz LGTM. Thanks

@ruflin ruflin merged commit 81b48a6 into ruflin:master Feb 21, 2017

3 checks passed

codecov/patch 100% of diff hit (target 84.31%)
Details
codecov/project 84.31% (+<.01%) compared to 035854e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thePanz thePanz deleted the thePanz:fix-analyze-api-explain branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment