Keep track of neccessary scroll pages to skip useless last request #1273

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
2 participants
@Tobion
Collaborator

Tobion commented Mar 16, 2017

Fixes #1234

@ruflin

ruflin approved these changes Mar 17, 2017

LGTM. Changelog entry? :-)

*
* @var array
*/
- protected $_options = [null, null, null];

This comment has been minimized.

@ruflin

ruflin Mar 17, 2017

Owner

search type was never used?

@ruflin

ruflin Mar 17, 2017

Owner

search type was never used?

This comment has been minimized.

@Tobion

Tobion Mar 20, 2017

Collaborator

It got removed before already with es upgrade

@Tobion

Tobion Mar 20, 2017

Collaborator

It got removed before already with es upgrade

@Tobion

This comment has been minimized.

Show comment
Hide comment
@Tobion

Tobion Mar 20, 2017

Collaborator

Added changelog

Collaborator

Tobion commented Mar 20, 2017

Added changelog

@ruflin ruflin merged commit ec75c5c into ruflin:master Mar 20, 2017

3 checks passed

codecov/patch 100% of diff hit (target 84.33%)
Details
codecov/project 84.35% (+0.02%) compared to 497fb09
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Mar 20, 2017

Owner

@Tobion Thanks, merged.

Owner

ruflin commented Mar 20, 2017

@Tobion Thanks, merged.

@Tobion Tobion deleted the Tobion:scroll-optimization branch Mar 20, 2017

mhernik pushed a commit to mhernik/Elastica that referenced this pull request Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment