New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span queries #1319

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
2 participants
@alekitto
Contributor

alekitto commented Jun 1, 2017

Fixes #1316

  • span_term
  • span_multi
  • span_first
  • span_near
  • span_or
  • span_containing
  • span_within
  • span_not
  • field_masking_span

@ruflin ruflin referenced this pull request Jun 2, 2017

Merged

Added few Span queries #1320

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 25, 2017

Owner

#1320 is now merged. This probably needs rebase now.

Owner

ruflin commented Jul 25, 2017

#1320 is now merged. This probably needs rebase now.

@alekitto

This comment has been minimized.

Show comment
Hide comment
@alekitto

alekitto Jul 26, 2017

Contributor

I've rebased and squashed my work.
The only thing left is the field_masking_span, but it's barely documented (there's only an example), so i think we could leave this out, as the implementation of the query class would be probably wrong.

Contributor

alekitto commented Jul 26, 2017

I've rebased and squashed my work.
The only thing left is the field_masking_span, but it's barely documented (there's only an example), so i think we could leave this out, as the implementation of the query class would be probably wrong.

@ruflin

LGTM. See my minor comment. This could be applied to all setters in the PR.

For field_masking_span agree that we can tackle that in case someone needs it actually.

Show outdated Hide outdated lib/Elastica/Query/SpanContaining.php
@alekitto

This comment has been minimized.

Show comment
Hide comment
@alekitto

alekitto Jul 27, 2017

Contributor

Ok, fixed all the setters in SpanContaining, SpanNot, SpanWithin and SpanNear (missed in #1320)

Contributor

alekitto commented Jul 27, 2017

Ok, fixed all the setters in SpanContaining, SpanNot, SpanWithin and SpanNear (missed in #1320)

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2017

Owner

@alekitto In the diff Builder.php shows up and I'm not sure why?

Owner

ruflin commented Jul 27, 2017

@alekitto In the diff Builder.php shows up and I'm not sure why?

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2017

Owner

BTW: Could you also add an entry to the changelog?

Owner

ruflin commented Jul 27, 2017

BTW: Could you also add an entry to the changelog?

@alekitto

This comment has been minimized.

Show comment
Hide comment
@alekitto

alekitto Jul 27, 2017

Contributor

Builder.php is an empty file, I probably deleted it without noticing.
The Changelog already contains a line for Span* queries addition. Do I have to add another one for these three?

Contributor

alekitto commented Jul 27, 2017

Builder.php is an empty file, I probably deleted it without noticing.
The Changelog already contains a line for Span* queries addition. Do I have to add another one for these three?

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2017

Owner

Argh, it seems some things got mixed up in the Changelog :-( The reason an additional entry is needed because just yesterday happened a release. So this goes into the next release.

Owner

ruflin commented Jul 27, 2017

Argh, it seems some things got mixed up in the Changelog :-( The reason an additional entry is needed because just yesterday happened a release. So this goes into the next release.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jul 27, 2017

Owner

I just pushed a change to the CHANGELOG to bring it up-to-date. Make sure to get the most recent one in before updating it.

Owner

ruflin commented Jul 27, 2017

I just pushed a change to the CHANGELOG to bring it up-to-date. Make sure to get the most recent one in before updating it.

@alekitto alekitto changed the title from [WIP] add span queries to Add span queries Jul 27, 2017

@alekitto

This comment has been minimized.

Show comment
Hide comment
@alekitto

alekitto Jul 27, 2017

Contributor

👍 Done.

Contributor

alekitto commented Jul 27, 2017

👍 Done.

@ruflin

ruflin approved these changes Jul 27, 2017

Thanks. Waiting for green.

@ruflin ruflin merged commit 0d10e3e into ruflin:master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment