GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1320 is now merged. This probably needs rebase now.
I've rebased and squashed my work.
The only thing left is the field_masking_span, but it's barely documented (there's only an example), so i think we could leave this out, as the implementation of the query class would be probably wrong.
LGTM. See my minor comment. This could be applied to all setters in the PR.
For field_masking_span agree that we can tackle that in case someone needs it actually.
Ok, fixed all the setters in SpanContaining, SpanNot, SpanWithin and SpanNear (missed in #1320)
@alekitto In the diff Builder.php shows up and I'm not sure why?
BTW: Could you also add an entry to the changelog?
Builder.php is an empty file, I probably deleted it without noticing.
The Changelog already contains a line for Span* queries addition. Do I have to add another one for these three?
Argh, it seems some things got mixed up in the Changelog :-( The reason an additional entry is needed because just yesterday happened a release. So this goes into the next release.
I just pushed a change to the CHANGELOG to bring it up-to-date. Make sure to get the most recent one in before updating it.
Thanks. Waiting for green.
add span_containing, span_not and span_within queries