New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose getNumberOfReplicas() from index settings #1324

Merged
merged 2 commits into from Jun 13, 2017

Conversation

Projects
None yet
2 participants
@thePanz
Contributor

thePanz commented Jun 8, 2017

The index settings exposes most of the available settings, while for the numberOfReplicas the "get" method is missing

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jun 13, 2017

Owner

LGTM. Could you add a changelog entry?

Owner

ruflin commented Jun 13, 2017

LGTM. Could you add a changelog entry?

@thePanz thePanz changed the title from Expose getNumberOfReplicas() from index settings to WIP: Expose getNumberOfReplicas() from index settings Jun 13, 2017

@thePanz

This comment has been minimized.

Show comment
Hide comment
@thePanz

thePanz Jun 13, 2017

Contributor

@ruflin Changelog added, plus:

  • fixed a typo in the test name (it was "shards" instead of "replicas")
  • removed usage of empty, as we can set 0 (zero) replicas
Contributor

thePanz commented Jun 13, 2017

@ruflin Changelog added, plus:

  • fixed a typo in the test name (it was "shards" instead of "replicas")
  • removed usage of empty, as we can set 0 (zero) replicas

@ruflin ruflin merged commit 464899a into ruflin:master Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Jun 13, 2017

Owner

Thanks, merged.

Owner

ruflin commented Jun 13, 2017

Thanks, merged.

@thePanz thePanz changed the title from WIP: Expose getNumberOfReplicas() from index settings to Expose getNumberOfReplicas() from index settings Jun 13, 2017

@thePanz thePanz deleted the thePanz:expose-settings-get-number-of-replicas branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment