New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze removed support for request parameters #1370

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
2 participants
@p365labs
Collaborator

p365labs commented Sep 2, 2017

Analyze endpoint removed support for request parameters, we should use request body instead. I updated the Analyze endpoint in order to accept not only text, but an array of values, so even the explain functionality will work.

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Sep 4, 2017

Owner

Guest what ... ^

Owner

ruflin commented Sep 4, 2017

Guest what ... ^

@p365labs

This comment has been minimized.

Show comment
Hide comment
@p365labs

p365labs Sep 4, 2017

Collaborator

sorry I make some mistakes between comments and review ... ;)

  • I updated the docblock as $body should be and array
  • I declared $body as array forcing the strict type
    what do u think ? should we really raise an error in case of $body not a map ?
Collaborator

p365labs commented Sep 4, 2017

sorry I make some mistakes between comments and review ... ;)

  • I updated the docblock as $body should be and array
  • I declared $body as array forcing the strict type
    what do u think ? should we really raise an error in case of $body not a map ?

@ruflin ruflin merged commit 41e8163 into ruflin:master Sep 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Sep 5, 2017

Owner

I like the strict typing of array. This will also show developers and error very quickly which hopefully pushes them to read the changelog :-)

Owner

ruflin commented Sep 5, 2017

I like the strict typing of array. This will also show developers and error very quickly which hopefully pushes them to read the changelog :-)

@p365labs

This comment has been minimized.

Show comment
Hide comment
@p365labs

p365labs Sep 5, 2017

Collaborator

I like strict type hinting too... maybe when this major upgrade has ended we could plan a major refactor in order to make Elastica more respectful of it, considering we are now upgraded to php7.
Just an idea :)

Collaborator

p365labs commented Sep 5, 2017

I like strict type hinting too... maybe when this major upgrade has ended we could plan a major refactor in order to make Elastica more respectful of it, considering we are now upgraded to php7.
Just an idea :)

@p365labs p365labs deleted the p365labs:es6_remove_explain_query_param branch Sep 5, 2017

@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Sep 5, 2017

Owner

I like the idea as it will make devs detect problems much earlier. But it will definitively break all older versions (which is probably fine looking at http://php.net/supported-versions.php).

Owner

ruflin commented Sep 5, 2017

I like the idea as it will make devs detect problems much earlier. But it will definitively break all older versions (which is probably fine looking at http://php.net/supported-versions.php).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment