New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented join datatype #1383

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@p365labs
Collaborator

p365labs commented Oct 3, 2017

Implemented join datatype and solved all failing tests :

The join datatype is a special field that creates parent/child relation within documents of the same index. The relations section defines a set of possible relations within the documents, each relation being a parent name and a child name.

@p365labs p365labs requested a review from ruflin Oct 3, 2017

@ruflin ruflin merged commit 81123eb into ruflin:master Oct 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Oct 3, 2017

Owner

Wow, that PR is quite an effort on cleaning / fixing the tests. Thanks a lot.

Owner

ruflin commented Oct 3, 2017

Wow, that PR is quite an effort on cleaning / fixing the tests. Thanks a lot.

@p365labs p365labs deleted the p365labs:es6_use_join_fields branch Oct 3, 2017

@p365labs

This comment has been minimized.

Show comment
Hide comment
@p365labs

p365labs Oct 3, 2017

Collaborator

in fact all tests are fixed now ;) The only that are skipped are the ones that remains for php 5.x which are not working in php 7 (Null, Bool are reserved words in php 7).

Collaborator

p365labs commented Oct 3, 2017

in fact all tests are fixed now ;) The only that are skipped are the ones that remains for php 5.x which are not working in php 7 (Null, Bool are reserved words in php 7).

p365labs added a commit to p365labs/Elastica that referenced this pull request Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment