New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to es6-rc2 #1398

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@p365labs
Collaborator

p365labs commented Nov 2, 2017

This PR will

  • update the docker image to ES6 RC2
  • removed xdebug 2.4 from the Dockerfile as it could lead to some errors on TRAVIS. Travis already has xdebug
  • solves a BC break on innerHits Query
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Nov 6, 2017

Owner

Thanks for the PR. Any chance you could move the innerHits change to an other PR?

For the xdebug part: How does it help that xdebug is already part of Travis as these tests run inside the docker containers?

Owner

ruflin commented Nov 6, 2017

Thanks for the PR. Any chance you could move the innerHits change to an other PR?

For the xdebug part: How does it help that xdebug is already part of Travis as these tests run inside the docker containers?

@p365labs

This comment has been minimized.

Show comment
Hide comment
@p365labs

p365labs Nov 6, 2017

Collaborator

The problem splitting the PR is that the BC has been introduced exactly by the RC2. So testInnerHitsNested will fail and so the build if I split the PR in two PR's.

It's a bit weird they have introduced this BC in ES-6-beta2 and then introduced (in RC2) the BC Break of a BC Break...
It shows to Elastic is working hard in order to release the new ES6.ù

Xdebug, it's ok, it's tru what u said. It's that I noticed that sometimes tests fail due to this error :

Step 6/13 : RUN pecl install xdebug-2.4.0
 ---> Running in b33bc5554f34
Package "xdebug" Version "2.4.0" does not have REST xml available
install failed

and I still don't understand, I thought removing it will solve the problem. Maybe I need to inspect on that more ;)

Collaborator

p365labs commented Nov 6, 2017

The problem splitting the PR is that the BC has been introduced exactly by the RC2. So testInnerHitsNested will fail and so the build if I split the PR in two PR's.

It's a bit weird they have introduced this BC in ES-6-beta2 and then introduced (in RC2) the BC Break of a BC Break...
It shows to Elastic is working hard in order to release the new ES6.ù

Xdebug, it's ok, it's tru what u said. It's that I noticed that sometimes tests fail due to this error :

Step 6/13 : RUN pecl install xdebug-2.4.0
 ---> Running in b33bc5554f34
Package "xdebug" Version "2.4.0" does not have REST xml available
install failed

and I still don't understand, I thought removing it will solve the problem. Maybe I need to inspect on that more ;)

@ruflin ruflin merged commit 0671a8f into ruflin:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Show comment
Hide comment
@ruflin

ruflin Nov 7, 2017

Owner

PR merged. For the xdebug issue: As far as I remember xdebug is needed for the coverage report, so I think we still need it but we should fix the above issue. Perhaps it's just an old version? Haven't looked at xdebug in ages.

Owner

ruflin commented Nov 7, 2017

PR merged. For the xdebug issue: As far as I remember xdebug is needed for the coverage report, so I think we still need it but we should fix the above issue. Perhaps it's just an old version? Haven't looked at xdebug in ages.

@p365labs p365labs deleted the p365labs:update_to_es6_rc2 branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment