New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request params to client->deleteDocuments #1419

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@fvilpoix
Contributor

fvilpoix commented Dec 6, 2017

To have the same behaviour than addDocuments or updateDocuments.

@ruflin

This comment has been minimized.

Owner

ruflin commented Dec 7, 2017

Could you update the CHANGELOG and add a functional test if possible?

@fvilpoix

This comment has been minimized.

Contributor

fvilpoix commented Dec 7, 2017

Here is the update, thanks for your review :)

@ruflin ruflin merged commit 412f866 into ruflin:master Dec 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Owner

ruflin commented Dec 8, 2017

@fvilpoix Merged. Thanks a lot for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment