Request Params passed to Client through Index and Type#1427
Merged
ruflin merged 2 commits intoruflin:masterfrom Dec 21, 2017
Merged
Request Params passed to Client through Index and Type#1427ruflin merged 2 commits intoruflin:masterfrom
ruflin merged 2 commits intoruflin:masterfrom
Conversation
Owner
|
Could you add a line to the CHANGELOG? I restart travis as the failure seemed to be unrelated. |
Author
|
Done with CHANGELOG. |
Owner
|
@p365labs Not sure if the failure here is a new issue we have on travis? |
Owner
…ments methods of Type and Index classes. It is passed to Client's methods which already have that parameter
Author
|
@ruflin Done. Thank you for your help! |
Owner
|
@akadko Thanks, merged. Normally I would ask for some tests but I think here it's pretty straight forward as it uses existing methods. If you get some time to add tests in a follow up PR I definitively wont say no ;-) |
Author
|
@ruflin Yes, I should and I will, of course :-). Sorry I had no enough time before |
Owner
|
@akadko Great to hear, looking forward to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client's methods for updating and adding document have non-required array argument requestParams which can be used, for example, for specifying a pipeline. I added the same argument to the corresponding methods of Index and Type classes.