New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sum_bucket & avg_bucket aggregations #1443

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
3 participants
@josselinh
Copy link
Contributor

josselinh commented Jan 24, 2018

Hello @ruflin

I need sum_bucket & avg_bucket, so I added them.

Hope it's ok

#1279

@josselinh josselinh force-pushed the josselinh:sum_avg_bucket branch from e831f39 to 69a3c20 Jan 24, 2018

@josselinh

This comment has been minimized.

Copy link
Contributor Author

josselinh commented Jan 24, 2018

Just FYI, I have ElasticSearch 5.6

@XWB

This comment has been minimized.

Copy link
Contributor

XWB commented Jan 24, 2018

Perfect timing as we need sum_bucket as well.

@ruflin Please consider this PR before releasing 5.3.1 :)

@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented Jan 26, 2018

@josselinh Can you add some tests to this and a CHANGELOG?

Also it would be great to also have this in master. I suggest to have first a PR against master and then cherry pick it to 5.x.

@josselinh josselinh force-pushed the josselinh:sum_avg_bucket branch 2 times, most recently from 1b20dcd to 13a75ce Jan 26, 2018

@josselinh josselinh force-pushed the josselinh:sum_avg_bucket branch from 13a75ce to 68d81e0 Jan 26, 2018

@josselinh

This comment has been minimized.

Copy link
Contributor Author

josselinh commented Jan 26, 2018

Hello @ruflin,
I modified the changelog and added the tests as you wanted.
I'll make you a new PR for the branch master later.

@ruflin ruflin merged commit 3c4b38c into ruflin:5.x Jan 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented Jan 28, 2018

@josselinh Thanks a lot for the contribution and also the tests. Can you directly open the PR against master to make sure we don't forget about it and have all the features from 5.x also in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment