Add support for multiple bucket sort orders #1480
Merged
Conversation
|
@cjost1988 Thank you for the high quality PR. Changelog, linting, tests - everything there |
|
lol I just wanted to add the pull request link in the changelog :D Thank you for your quick process. Glad to help improving. |
|
haha, missed that one. Feel free to open an other PR, otherwise will fix it on release day when going through the changelog. |
This was referenced Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Aggregation\Terms::setOrdersAggregation\Terms::setOrdersIf you want me to remove the linter fix, I'll can remove it. But I just followed the instructions and the linter changed the line. And since it was just one small change I took it into my PR.