Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple bucket sort orders #1480

Merged
merged 1 commit into from Apr 6, 2018

Conversation

@cjost1988
Copy link
Contributor

@cjost1988 cjost1988 commented Apr 6, 2018

  • Added Aggregation\Terms::setOrders
  • Added test for Aggregation\Terms::setOrders
  • Linter fixed another comment

If you want me to remove the linter fix, I'll can remove it. But I just followed the instructions and the linter changed the line. And since it was just one small change I took it into my PR.

@ruflin ruflin merged commit 7acab37 into ruflin:master Apr 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin
Copy link
Owner

@ruflin ruflin commented Apr 6, 2018

@cjost1988 Thank you for the high quality PR. Changelog, linting, tests - everything there ❤️

@cjost1988
Copy link
Contributor Author

@cjost1988 cjost1988 commented Apr 6, 2018

lol I just wanted to add the pull request link in the changelog :D

Thank you for your quick process. Glad to help improving.
And in the end we all benefit from good quality ;)

@ruflin
Copy link
Owner

@ruflin ruflin commented Apr 6, 2018

haha, missed that one. Feel free to open an other PR, otherwise will fix it on release day when going through the changelog.

@cjost1988
Copy link
Contributor Author

@cjost1988 cjost1988 commented Apr 6, 2018

@ruflin #1481 is containing the fix for the changelog.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.