Don't use deprecated `inline` field #1497
Merged
Conversation
|
Thanks for the fix. Code LGTM. Could you add a line to the changelog? |
|
Hey @ruflin, sure, should it go into |
`inline` field was deprecated in Elasticsearch 5.6
andrejbaran
force-pushed the
ftshp:fix/deprecated-inline
branch
from
efba4b5
to
11c5506
|
I have put it under |
|
@andrejbaran Thanks, LGTM. |
|
Thanks @ruflin just out of curiosity do you have any ETA on a new release? |
|
Now that I got 2 requests in 1 day, I should probably do one now. Will try to find some time today. |
|
Here you go: http://elastica.io/2018/05/29/release-6-dot-0-2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey there,
this changes script to use
sourcefield instead of deprecatedinline.Fixes #1416