New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated `inline` field #1497

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
2 participants
@andrejbaran
Contributor

andrejbaran commented May 24, 2018

Hey there,

this changes script to use source field instead of deprecated inline.

Fixes #1416

@ruflin

This comment has been minimized.

Owner

ruflin commented May 24, 2018

Thanks for the fix. Code LGTM. Could you add a line to the changelog?

@andrejbaran

This comment has been minimized.

Contributor

andrejbaran commented May 24, 2018

Hey @ruflin, sure, should it go into Bugfixes or Deprecated or Improvements ?

Don't use deprecated `inline` field
`inline` field was deprecated in Elasticsearch 5.6
@andrejbaran

This comment has been minimized.

Contributor

andrejbaran commented May 24, 2018

I have put it under Improvements since that imho fits most :)

@ruflin ruflin merged commit 1b098c3 into ruflin:master May 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Owner

ruflin commented May 25, 2018

@andrejbaran Thanks, LGTM.

@s7anley s7anley deleted the ftshp:fix/deprecated-inline branch May 27, 2018

@andrejbaran

This comment has been minimized.

Contributor

andrejbaran commented May 28, 2018

Thanks @ruflin just out of curiosity do you have any ETA on a new release?

@ruflin

This comment has been minimized.

Owner

ruflin commented May 29, 2018

Now that I got 2 requests in 1 day, I should probably do one now. Will try to find some time today.

@ruflin

This comment has been minimized.

Owner

ruflin commented May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment