Added updateByQuery endpoint #1499
Conversation
|
Solves #1103 |
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Changes LGTM. Left a few minor comments to the code docs.
Thanks a lot for using the elasticsearch-php functions to create this endpoint.
test/Elastica/IndexTest.php
Outdated
|
|
||
| /** | ||
| * @group functional | ||
| * @group mmoreram |
There was a problem hiding this comment.
What does the second group here mean and what is it for?
test/Elastica/IndexTest.php
Outdated
| $response = $index->search('nicolas'); | ||
| $this->assertEquals(1, $response->count()); | ||
|
|
||
| // Delete first document |
There was a problem hiding this comment.
This only renames it and does not delete it?
test/Elastica/IndexTest.php
Outdated
|
|
||
| $index->refresh(); | ||
|
|
||
| // Makes sure, document is deleted |
There was a problem hiding this comment.
See comment above, it makes sure document is renamed.
test/Elastica/IndexTest.php
Outdated
| $response = $index->search('nicolas'); | ||
| $this->assertEquals(1, $response->count()); | ||
|
|
||
| // Delete first document |
test/Elastica/IndexTest.php
Outdated
|
|
||
| $index->refresh(); | ||
|
|
||
| // Makes sure, document is deleted |
|
Fixed all docs. I'm sorry, my mistake I didn't check properly tests :) |
|
@mmoreram Thanks a lot for the contribution. |
|
@ruflin thanks to you, for this library :=) When do you expect you will release next stable version? |
|
Here you go: http://elastica.io/2018/05/29/release-6-dot-0-2/ |
|
@ruflin WEEEE That deserves a beer if you come to Barcelona ! :D Thanks so much! |
2 participants
Uh oh!
There was an error while loading. Please reload this page.