Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updateByQuery endpoint #1499

Merged
merged 1 commit into from May 28, 2018
Merged

Added updateByQuery endpoint #1499

merged 1 commit into from May 28, 2018

Conversation

@mmoreram
Copy link
Contributor

@mmoreram mmoreram commented May 25, 2018

  • Added Changelog entry as well under Added block
@mmoreram
Copy link
Contributor Author

@mmoreram mmoreram commented May 26, 2018

Solves #1103

Loading

Copy link
Owner

@ruflin ruflin left a comment

Changes LGTM. Left a few minor comments to the code docs.

Thanks a lot for using the elasticsearch-php functions to create this endpoint.

Loading

@@ -290,6 +291,76 @@ public function testDeleteByQueryWithQueryAndOptions()
$this->assertEquals(0, $response->count());
}

/**
* @group functional
* @group mmoreram
Copy link
Owner

@ruflin ruflin May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the second group here mean and what is it for?

Loading

$response = $index->search('nicolas');
$this->assertEquals(1, $response->count());

// Delete first document
Copy link
Owner

@ruflin ruflin May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only renames it and does not delete it?

Loading


$index->refresh();

// Makes sure, document is deleted
Copy link
Owner

@ruflin ruflin May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above, it makes sure document is renamed.

Loading

$response = $index->search('nicolas');
$this->assertEquals(1, $response->count());

// Delete first document
Copy link
Owner

@ruflin ruflin May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates all docs?

Loading


$index->refresh();

// Makes sure, document is deleted
Copy link
Owner

@ruflin ruflin May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Loading

@mmoreram
Copy link
Contributor Author

@mmoreram mmoreram commented May 28, 2018

Fixed all docs. I'm sorry, my mistake I didn't check properly tests :)

Loading

@ruflin ruflin merged commit 1d169b6 into ruflin:master May 28, 2018
1 check passed
Loading
@ruflin
Copy link
Owner

@ruflin ruflin commented May 28, 2018

@mmoreram Thanks a lot for the contribution.

Loading

@mmoreram mmoreram deleted the feature/update-by-query branch May 28, 2018
@mmoreram
Copy link
Contributor Author

@mmoreram mmoreram commented May 28, 2018

@ruflin thanks to you, for this library :=)

When do you expect you will release next stable version?

Loading

@ruflin
Copy link
Owner

@ruflin ruflin commented May 29, 2018

Loading

@mmoreram
Copy link
Contributor Author

@mmoreram mmoreram commented May 29, 2018

@ruflin WEEEE

That deserves a beer if you come to Barcelona ! :D

Thanks so much!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants