Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updateByQuery endpoint #1499

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@mmoreram
Copy link
Contributor

mmoreram commented May 25, 2018

  • Added Changelog entry as well under Added block
@mmoreram

This comment has been minimized.

Copy link
Contributor Author

mmoreram commented May 26, 2018

Solves #1103

@ruflin
Copy link
Owner

ruflin left a comment

Changes LGTM. Left a few minor comments to the code docs.

Thanks a lot for using the elasticsearch-php functions to create this endpoint.

@@ -290,6 +291,76 @@ public function testDeleteByQueryWithQueryAndOptions()
$this->assertEquals(0, $response->count());
}
/**
* @group functional
* @group mmoreram

This comment has been minimized.

@ruflin

ruflin May 28, 2018

Owner

What does the second group here mean and what is it for?

$response = $index->search('nicolas');
$this->assertEquals(1, $response->count());
// Delete first document

This comment has been minimized.

@ruflin

ruflin May 28, 2018

Owner

This only renames it and does not delete it?

$index->refresh();
// Makes sure, document is deleted

This comment has been minimized.

@ruflin

ruflin May 28, 2018

Owner

See comment above, it makes sure document is renamed.

$response = $index->search('nicolas');
$this->assertEquals(1, $response->count());
// Delete first document

This comment has been minimized.

@ruflin

ruflin May 28, 2018

Owner

Updates all docs?

$index->refresh();
// Makes sure, document is deleted

This comment has been minimized.

@ruflin

ruflin May 28, 2018

Owner

See above

mmoreram added a commit to apisearch-io/search-server that referenced this pull request May 28, 2018

Added Update items endpoint in Apisearch server
- By using the new library features, Apisearch is able to add updates on existing indices.
- Blocked by ruflin/Elastica#1499 to be merged in master, and while is not tagged, elastica deps will turn to dev-master

mmoreram added a commit to apisearch-io/search-server that referenced this pull request May 28, 2018

Added Update items endpoint in Apisearch server
- By using the new library features, Apisearch is able to add updates on existing indices.
- Blocked by ruflin/Elastica#1499 to be merged in master, and while is not tagged, elastica deps will turn to dev-master
@mmoreram

This comment has been minimized.

Copy link
Contributor Author

mmoreram commented May 28, 2018

Fixed all docs. I'm sorry, my mistake I didn't check properly tests :)

mmoreram added a commit to apisearch-io/search-server that referenced this pull request May 28, 2018

Added Update items endpoint in Apisearch server
- By using the new library features, Apisearch is able to add updates on existing indices.
- Blocked by ruflin/Elastica#1499 to be merged in master, and while is not tagged, elastica deps will turn to dev-master
- Tests are momentanously disabled

@ruflin ruflin merged commit 1d169b6 into ruflin:master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented May 28, 2018

@mmoreram Thanks a lot for the contribution.

@mmoreram mmoreram deleted the mmoreram:feature/update-by-query branch May 28, 2018

@mmoreram

This comment has been minimized.

Copy link
Contributor Author

mmoreram commented May 28, 2018

@ruflin thanks to you, for this library :=)

When do you expect you will release next stable version?

@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented May 29, 2018

@mmoreram

This comment has been minimized.

Copy link
Contributor Author

mmoreram commented May 29, 2018

@ruflin WEEEE

That deserves a beer if you come to Barcelona ! :D

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.