Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Term Suggester, test multiple completion suggestions #1543

Merged
merged 1 commit into from Dec 3, 2018

Conversation

@p365labs
Copy link
Collaborator

@p365labs p365labs commented Nov 30, 2018

In reference #1541 I made some more tests, I also addedd a method for choosing the distance algorithm

@p365labs
Copy link
Collaborator Author

@p365labs p365labs commented Nov 30, 2018

This PR in fact add a test in order to verify the #1541 to have a use case that cover that example.
I've also added a method

public function setStringDistanceAlgorithm($distanceAlgorithm)

and its test to include this option which was not in the class.

@ruflin
Copy link
Owner

@ruflin ruflin commented Dec 3, 2018

Code LGTM. Want to add a changelog entry?

@p365labs p365labs force-pushed the p365labs:add_suggestion_bug branch from d6a4912 to e5c7492 Dec 3, 2018
@p365labs
Copy link
Collaborator Author

@p365labs p365labs commented Dec 3, 2018

@ruflin done :)

@ruflin ruflin merged commit 7232cd6 into ruflin:master Dec 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@p365labs p365labs deleted the p365labs:add_suggestion_bug branch Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.