Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Derivative Aggregation #1553

Merged
merged 7 commits into from Dec 17, 2018
Merged

Conversation

@maltehuebner
Copy link
Contributor

@maltehuebner maltehuebner commented Dec 11, 2018

I added a class to perform Derivative aggregations and wrote a small test case for it.

Copy link
Owner

@ruflin ruflin left a comment

Thanks for the contribution. Could you add a changelog entry?

* master:
  update to ES 6.5.2 and to LATEST PHP 7.3 official relase (#1552)
  Prepare for 6.1.0 release (#1547)
  test connection error (#1546)
  Add php73 support and Xdebug (#1545)
@maltehuebner
Copy link
Contributor Author

@maltehuebner maltehuebner commented Dec 11, 2018

I added just a line to changelog, is that fine?

lib/Elastica/Aggregation/Derivative.php Outdated Show resolved Hide resolved
@maltehuebner
Copy link
Contributor Author

@maltehuebner maltehuebner commented Dec 13, 2018

I added your feedback to the pull request, please have a look on it :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 17, 2018

@ruflin for me it's ok to be merged

@ruflin
Copy link
Owner

@ruflin ruflin commented Dec 17, 2018

@p365labs Go for it ;-)

@ruflin
ruflin approved these changes Dec 17, 2018
@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 17, 2018

@ruflin "squash and merge ?"

@ruflin
Copy link
Owner

@ruflin ruflin commented Dec 17, 2018

@p365labs Yes

@p365labs p365labs merged commit 332fcf6 into ruflin:master Dec 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
maltehuebner added a commit to maltehuebner/Elastica that referenced this pull request Dec 17, 2018
* master:
  Update composer dependencies (ruflin#1567)
  Add Derivative Aggregation (ruflin#1553)
@maltehuebner maltehuebner deleted the maltehuebner:derivative-aggregation branch Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants