Merged
Conversation
ruflin
reviewed
Dec 11, 2018
Owner
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Could you add a changelog entry?
* master: update to ES 6.5.2 and to LATEST PHP 7.3 official relase (ruflin#1552) Prepare for 6.1.0 release (ruflin#1547) test connection error (ruflin#1546) Add php73 support and Xdebug (ruflin#1545)
Contributor
Author
|
I added just a line to changelog, is that fine? |
p365labs
requested changes
Dec 11, 2018
Contributor
Author
|
I added your feedback to the pull request, please have a look on it :) |
ruflin
requested changes
Dec 13, 2018
p365labs
approved these changes
Dec 13, 2018
ruflin
reviewed
Dec 14, 2018
Collaborator
|
@ruflin for me it's ok to be merged |
Owner
|
@p365labs Go for it ;-) |
ruflin
approved these changes
Dec 17, 2018
Collaborator
|
@ruflin "squash and merge ?" |
Owner
|
@p365labs Yes |
maltehuebner
added a commit
to maltehuebner/Elastica
that referenced
this pull request
Dec 17, 2018
* master: Update composer dependencies (ruflin#1567) Add Derivative Aggregation (ruflin#1553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a class to perform
Derivativeaggregations and wrote a small test case for it.