empty the raw response string after parsing #1588
Conversation
|
@dbu that's really interesting.. I've had a look at the code and _responseString is never accessed after the use in getData(). Does it really created a problem in memory consumption ? Glad that you discovered it, maybe this could save life to lot of people :) Do you think that this could be the only way to solve it ? |
|
we have queries where the raw json is several megabytes, so yes, duplicating that is a cost. another option would be to parse in the constructor and never even set the raw string. that would mean a performance penalty if the result is not used at all, not sure if that is likely to happen. might be for changing requests that the http status is enough to know it worked... this change looked like the smallest impact where we can be sure there is no negative side effect in any circumstate. |
|
I agree with you. I think we can proceed this way right now. @ruflin what do you think on this ? |
|
👍 on the change. A changelog entry would be nice. |
when a query yields a large response, duplicating the data between string and parsed array duplicates the memory consumption. once $this->_response is set, $this->_responseString is not accessed anywhere in the code anymore.
|
added a changelog entry. ok like this? |
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM, assuming CI goes green ;-)
3 participants
when a query yields a large response, duplicating the data between string and parsed array duplicates the memory consumption.
once $this->_response is set, $this->_responseString is not accessed anywhere in the code anymore.