Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer native_function_invocation rule #1606

Merged

Conversation

@massimilianobraglia
Copy link
Contributor

massimilianobraglia commented Feb 8, 2019

Introduced php-cs-fixer native_function_invocation rule and applied linting

@p365labs

This comment has been minimized.

Copy link
Collaborator

p365labs commented Feb 11, 2019

@massimilianobraglia :

  • why introducing native_function_invocation right now?
  • is this process to be applied during linting? if so why no applying during a new release?
@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented Feb 11, 2019

This change would also need a CHANGELOG entry. Are there cases where this could break things (certain PHP versions?).

@massimilianobraglia

This comment has been minimized.

Copy link
Contributor Author

massimilianobraglia commented Feb 12, 2019

@p365labs:

  1. because we said in #1540 to open multiple PRs to introduce new CS rules
  2. yes, it is. Unfortunately I had no time to work on this at the moment the release was created

@ruflin ok about adding a changelog entry (I'll do it right now). The case this could break things is where someone in his codebase mocked the built-in functions I think

…inting
@massimilianobraglia massimilianobraglia force-pushed the massimilianobraglia:native_function_invocation branch from ff7d42c to 33937ff Feb 12, 2019
Copy link
Owner

ruflin left a comment

LGTM.

For the mocking of the built in functions I assume that would be a testing use case? To make sure we don't break anything we probably best don't backport this to 6.x.

@@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file based on the
### Added

### Improvements
* Added `native_function_invocation` CS rule

This comment has been minimized.

Copy link
@ruflin

ruflin Feb 12, 2019

Owner

Can you add the PR number / link to it?

This comment has been minimized.

Copy link
@massimilianobraglia

massimilianobraglia Feb 12, 2019

Author Contributor

Yep! Sorry about that 😄

@massimilianobraglia massimilianobraglia force-pushed the massimilianobraglia:native_function_invocation branch from 33937ff to 4d98f45 Feb 12, 2019
@massimilianobraglia

This comment has been minimized.

Copy link
Contributor Author

massimilianobraglia commented Feb 12, 2019

For the mocking of the built in functions I assume that would be a testing use case?

Yep, exactly

@ruflin
ruflin approved these changes Feb 12, 2019
Copy link
Owner

ruflin left a comment

LGTM. Let's see if @p365labs has concerns.

@p365labs

This comment has been minimized.

Copy link
Collaborator

p365labs commented Feb 18, 2019

@massimilianobraglia & @ruflin make sense to me.

  • So let's use this on linting
  • don't backport it to 6.x branch
@p365labs p365labs merged commit 9541a3b into ruflin:master Feb 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.