Fix JSON float formatting

[pySilver]

See #1634 for details

[ruflin]

Interesting addition, didn't even know this constant exists. I'm trying to think of any existing deployments we might break with this. In the case someone defined it as integer on the Elasticsearch side already and a float is sent, as far as I know it will just convert it back to integer and keep working. Any ideas on what it could break?

@ezimuel Any thoughts related to this?

@pySilver Could you also add a CHANGELOG entry and some tests to it?

[pySilver]

@ruflin I can't see any way it can brake a valid setup here since on both sides data will be in a proper/expected type.

Btw, its a default JSON serialization flag in elasticsearch-php library for a long time already: elastic/elasticsearch-php#481

I'll add changelog entry in a moment, but I'm unable to add tests (I've switched back from python not so long ago and not yet familiar with PHP tests yet)

[ezimuel]

@ruflin, I agree to add JSON_PRESERVE_ZERO_FRACTION for json_encode, we used it in elasticserach-php, as suggested by @pySilver.
I'm not sure about the fix proposed by @pySilver, since the JSON::stringify is also used in other Elastica classes. Instead of change all the stringify calls why don't add JSON_PRESERVE_ZERO_FRACTION directly in JSON::stringify as default parameter?

[ruflin]

Wasn't aware we also use it already in the official client. ++ on adding it then :-)

@pySilver WDYT about the proposal from @ezimuel ?

[pySilver]

@ruflin I think its totally correct and should be a default behavior for all serialization tasks.

[ruflin]

@pySilver Could you modify your PR to this approach?

[pySilver]

@ruflin done!

[ruflin]

Thanks. Could you try to run make lint. For some reason the linter in CI is happy. The strange thing is the file it complains about is not touched in this PR?!?

[pySilver]

@ruflin yeah, same thing on localhost. The reason is here: https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Index/Settings.php#L207 introduced 4m ago at #1569

(Bool should be bool), changing it in my pr.

[ruflin]

Had to read this line a few times but makes sense now :-)

[pySilver]

Yeah, kinda cryptic. I couldn't find easier way to append const if arg[1] is set/not set.

[chx]

$args[1] = ($args[1] ?? 0) | JSON_PRESERVE_ZERO_FRACTION;

[ruflin]

Thanks for chiming in @chx . Should we update the code?

[chx]

I think so :)

[ruflin]

@chx @pySilver Someone wants to take it? ;-)

[ruflin]

@pySilver Thanks for the fix, not sure how that Bool thingy slipped through for so long.