Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aggs): Add adjacency matrix aggregation #1642

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@Sharptsa
Copy link
Contributor

Sharptsa commented Jun 27, 2019

I added the AdjacencyMatrix aggregation

@Sharptsa Sharptsa force-pushed the Sharptsa:aggs_adjacency_matrix branch from 46f900f to 90bc1c9 Jun 28, 2019
@Sharptsa

This comment has been minimized.

Copy link
Contributor Author

Sharptsa commented Jul 1, 2019

Looks like there is an issue with the tests. It fails on my branch, but also on master on the same tests.
Don't know what is going on.

@Sharptsa Sharptsa force-pushed the Sharptsa:aggs_adjacency_matrix branch from 1adc579 to 6dbf3e4 Aug 6, 2019
@ruflin
ruflin approved these changes Aug 12, 2019
Copy link
Owner

ruflin left a comment

PR overall LGTM, sorry for the late reply. Seems like the testing stuff got sorted out? Could you make the small change an push again?

CHANGELOG.md Outdated Show resolved Hide resolved
@ruflin
ruflin approved these changes Aug 14, 2019
@ruflin ruflin merged commit 1642f6a into ruflin:master Aug 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented Aug 14, 2019

@Sharptsa Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.