Repository navigation
Add callable type hinting to Connection callback - #1659
Merged
Merged
Conversation
Owner
|
Code LGTM to me. Could you add a changelog entry just in case someone was using this in an unexpected way? |
franmomu
force-pushed
the
add_type_hinting_to_connection
branch
from
September 3, 2019 20:06
d5bd28e to
e2077b1
Compare
Contributor
Author
|
Sure! |
Owner
|
@franmomu Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$callbackparameter is only used inConnectionPoolwhich already has the type hint.