Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Query documentation #1679

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@thePanz
Copy link
Collaborator

@thePanz thePanz commented Oct 18, 2019

Cleanup Query documentation for ES-7

  • add ): self to fluent methods
  • remove un-needed @return $this annotations
  • Updated changelog for breaking changes
@thePanz thePanz force-pushed the improve-query-documentation-es-7 branch from 3d61716 to 838a148 Oct 18, 2019
lib/Elastica/Query.php Show resolved Hide resolved
lib/Elastica/Query.php Show resolved Hide resolved
lib/Elastica/Query.php Outdated Show resolved Hide resolved
@ruflin
Copy link
Owner

@ruflin ruflin commented Oct 21, 2019

Seems CI is not happy :-(

@thePanz thePanz force-pushed the improve-query-documentation-es-7 branch from 838a148 to 3645bdd Oct 22, 2019
ruflin
ruflin approved these changes Oct 22, 2019
@ruflin ruflin merged commit aee63ec into ruflin:master Oct 22, 2019
1 check passed
@ruflin
Copy link
Owner

@ruflin ruflin commented Oct 22, 2019

Thanks!

@thePanz thePanz deleted the improve-query-documentation-es-7 branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants