Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gitignore file #1753

Open
wants to merge 1 commit into
base: master
from
Open

Cleanup gitignore file #1753

wants to merge 1 commit into from

Conversation

@thePanz
Copy link
Collaborator

thePanz commented Feb 4, 2020

A .gitignore in a project should only cover artifacts caused by the contained source code, not those caused by the person

A .gitignore in a project should only cover artifacts caused by the contained source code, not those caused by the person
@thePanz thePanz mentioned this pull request Feb 4, 2020
4 of 4 tasks complete
@Tobion
Tobion approved these changes Feb 10, 2020
Copy link
Collaborator

Tobion left a comment

Fully agree. People should add those to their own global gitignore if they use certain tools.

@ruflin

This comment has been minimized.

Copy link
Owner

ruflin commented Feb 10, 2020

In theory I agree on the above, in practice I don't. It's not a burden I want to put on our contributors and even less on myself to check every PR for .DS_Store files or other files that were added accidentally and then ask the contributor to update his PR again. I rather have control on the repository end what must be ignored and what not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.