Dynamic mapping template (enhanced test) #359

Merged
merged 2 commits into from Apr 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

jappievw commented Apr 2, 2013

No description provided.

jappievw added some commits Apr 2, 2013

@jappievw jappievw Enhanced the Mapping Test to prevent undefined indices. 3c8b7a5
@jappievw jappievw Perform all checks down the chain
Just validating the existence of a property doesn't presume it is automatically created by the dynamic template.
3d5a09c

jappievw referenced this pull request Apr 2, 2013

Merged

Test case dynamic template #358

ruflin merged commit 4439efc into ruflin:master Apr 3, 2013

Owner

ruflin commented Apr 3, 2013

Lets see if everything goes green :-)

Contributor

jappievw commented Apr 3, 2013

It looks like it works again, although I didn't make a functional change!

/** Sent from my iPhone, sorry if brief. **/

On 3 apr. 2013, at 04:18, Nicolas Ruflin notifications@github.com wrote:

Lets see if everything goes green :-)


Reply to this email directly or view it on GitHub.

Owner

ruflin commented Apr 3, 2013

No comment ... Thx

Owner

ruflin commented Apr 11, 2013

It happened again that the build failed :-( I just talked to @s1monw and he showed me the env.ES_WAIT_ON_MAPPING_CHANGE flag. We should try to use this for travis to make elasticsearch "waiting" after the mapping change.

https://github.com/elasticsearch/elasticsearch/blob/master/pom.xml#L346

Owner

ruflin commented Jun 29, 2013

Let's see if it is going to fix the issue: 4a1217f

Contributor

jappievw commented Jul 1, 2013

Let's see and hope so! Would optimizing the index be of help? Probably it also reloads the mapping?

Owner

ruflin commented Jul 1, 2013

Looks like it is not really fixing the issue. Or at least there now seem to be other issues. Would could try optimizing to fix it. I would assume it would also reload the mapping as it is doing quite a lot.

@leahaense leahaense pushed a commit to liip-forks/Elastica that referenced this pull request Nov 20, 2013

@jappievw jappievw Optimize the index prior to testing the mapping.
Related to pull request ruflin#359
37efb21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment