Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"More Like This" Query #63

Merged
merged 4 commits into from Aug 7, 2011
Merged

"More Like This" Query #63

merged 4 commits into from Aug 7, 2011

Conversation

juneym
Copy link
Contributor

@juneym juneym commented Aug 5, 2011

No description provided.

@ruflin
Copy link
Owner

ruflin commented Aug 5, 2011

Hm, tests are also failing with ES 0.17.2 :-(

@ruflin
Copy link
Owner

ruflin commented Aug 5, 2011

Ah, you wrote 0.16.2 :-) not 0.17.2

@ruflin
Copy link
Owner

ruflin commented Aug 5, 2011

I hope shay or someone of the other guys can help:
https://groups.google.com/forum/#!topic/elasticsearch/oXCTNrZx99s

@ruflin
Copy link
Owner

ruflin commented Aug 5, 2011

I waiting with committins this pull request until we have the problem with ES 0.17.4 fixed. I made some comments into the code to remember the refactoring ...

@juneym
Copy link
Contributor Author

juneym commented Aug 5, 2011

Thanks. I also referred to the current doc so I was expecting that
everything will work using the latest ES version.

On Fri, Aug 5, 2011 at 7:33 PM, ruflin <
reply@reply.github.com>wrote:

I hope shay or someone of the other guys can help:
https://groups.google.com/forum/#!topic/elasticsearch/oXCTNrZx99s

Reply to this email directly or view it on GitHub:
#63 (comment)

@ruflin ruflin merged commit 0aeb7e3 into ruflin:master Aug 7, 2011
@ruflin
Copy link
Owner

ruflin commented Aug 7, 2011

I just merged the pull request. Tests are working now as I replaced fields through mlt_fields. But I'm not sure if the MLT Query is now working like expected (see forum post above).

@ruflin
Copy link
Owner

ruflin commented Aug 7, 2011

I just did some pretty heavy refactoring of the MoreLikeThis query in combination with the new introduced Elastica_Param object:
9973c8f

I plan to refactor all filter, queries and facets like this.

On main change I did is that if an invalid value is set (< 0) it is not reset to default. I think then an exception should be throw or at the moment it is up to the user to create valid queries. ES will throw and error as soon as the querie executes.

@juneym
Copy link
Contributor Author

juneym commented Aug 7, 2011

Thanks! I like the re-factored code. I will test the fixes using 0.16.2 as
well.

On Sun, Aug 7, 2011 at 6:30 PM, ruflin <
reply@reply.github.com>wrote:

I just did some pretty heavy refactoring of the MoreLikeThis query in
combination with the new introduced Elastica_Param object:

9973c8f

I plan to refactor all filter, queries and facets like this.

On main change I did is that if an invalid value is set (< 0) it is not
reset to default. I think then an exception should be throw or at the moment
it is up to the user to create valid queries. ES will throw and error as
soon as the querie executes.

Reply to this email directly or view it on GitHub:
#63 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants