Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Creates a developer environment using express #26

Merged
merged 13 commits into from Dec 3, 2021

Conversation

d80ep08th
Copy link

fixes #19

Creates a process that requests rugpullindex.com 's index side.
Serves this content to a developer after running : npm run dev

@TimDaub
Copy link
Member

TimDaub commented Dec 1, 2021

please put node_modules in .gitignore.

@il3ven
Copy link
Contributor

il3ven commented Dec 2, 2021

@d80ep08th The node_modules are still on your branch. Follow the steps here to remove them. https://stackoverflow.com/a/1139797

@TimDaub
Copy link
Member

TimDaub commented Dec 3, 2021

There were two commits that included all node_modules, so I had to do some rebasing to clean up the branch on your remote @d80ep08th. It's now ready for review. I also changed the licensing in bd0e75b.

Copy link
Member

@TimDaub TimDaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but I found a functional bug. To reproduce:

  1. Run npm run dev, check localhost:5000, website works and everything runs fine
  2. Kill the process
  3. Rerun npm run dev, now we get an error message
> design-system@1.0.0 dev /Users/user/Projects/rpi-design-system
> nodemon index.js

[nodemon] 2.0.15
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,json
[nodemon] starting `node index.js`
rugpullindex runs on localhost:5000/
[Error: EEXIST: file already exists, mkdir '/Users/user/Projects/rpi-design-system/cache'] {
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/user/Projects/rpi-design-system/cache'
}

Also: We should put the cache folder in .gitignore too.

@TimDaub TimDaub merged commit b58c387 into rugpullindex:master Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create developer environment
3 participants