Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

run github actions for multiple time-zones #28

Merged
merged 2 commits into from Oct 21, 2021

Conversation

il3ven
Copy link
Contributor

@il3ven il3ven commented Oct 21, 2021

This PR runs the current GitHub action workflow for various time-zones. See #24 for more context.

Here we use the fact that node's time zone can be changed by setting the TZ environment variable. In the workflow we set TZ env variable before running npm test. To run the workflow with different env variables we use jobs.<job_id>.strategy.matrix.

I tested the new workflow with the previous master and it failed as expected. Here are the logs for that.

Since in this approach the workflow runs multiple times I have also added cache support to keep the running time in check.

Fixes #27

@TimDaub
Copy link
Member

TimDaub commented Oct 21, 2021

Wow I learned something today! Great work @il3ven. I appreciate that you also included a test run log that shows the test mentioned in #24 failing. Makes it a pleasure to review!

@TimDaub TimDaub merged commit 995602c into rugpullindex:master Oct 21, 2021
2 checks passed
@il3ven il3ven deleted the test/githubActions branch October 21, 2021 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup a GitHub Action machine that runs tests in PST timezone
2 participants