Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added c8 code coverage and updated github actions #29

Merged
merged 1 commit into from Oct 25, 2021

Conversation

il3ven
Copy link
Contributor

@il3ven il3ven commented Oct 23, 2021

Fixes #13

  • Using c8 for collection code coverage
  • Added a script in package.json (npm run test:coverage)
  • Added a file .c8rc.json which stores the thresholds

Here's an GitHub action log of a previous run with high thresholds to see how it fails. https://github.com/il3ven/svg-line-chart/runs/3976488688?check_suite_focus=true

.c8rc.json contains thresholds for code coverage
Copy link
Member

@TimDaub TimDaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I tested locally and it works well.

@TimDaub TimDaub merged commit 516e59e into attestate:master Oct 25, 2021
@il3ven il3ven deleted the codeCoverage branch October 25, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage checks into Github Action checks
2 participants