Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS and pagination URLs not clean #263

Open
waynedpj opened this issue Jan 6, 2014 · 0 comments
Open

RSS and pagination URLs not clean #263

waynedpj opened this issue Jan 6, 2014 · 0 comments

Comments

@waynedpj
Copy link

waynedpj commented Jan 6, 2014

i have been researching this awhile and i apologize in advance for not coming up with a pull request, but my programming/Ruby skills are severely lacking and i wanted to document what i believe to be a bug while i have it in my brain's "front matter" ;)

i believe that i have discovered a possible bug: given a collection with a directory name like to do (note the spaces) and containing an index.html the resulting URL of the pagination files/folder (i.e. index, etc.) and rss.xml files generated by Ruhoh will still contain the space, though the actual collection contents will have the correct URL:

to-do/
└── index.html
to do/
├── index
│   └── 1
│       └── index.html
└── rss.xml

i have tracked the problem down to here for RSS and here for pagination though i cannot discover where the config['url'] is being set. i was temporarily able to fix the problem for RSS by wrapping the config['url'[ in Ruhoh::StringFormat.clean_slug_and_escape but i think it needs to be applied earlier since config['url'] is already returning the uncleaned URL before the actual file is created. unfortunately i have been unable to determine this spot yet.

thanks in advance for any pointers on how i can fix this and make a pull request.

peace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant