RSS feed converts relative urls to absolute urls #282

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@amanking
Contributor

amanking commented Mar 4, 2014

A common guideline is to use absolute urls instead of relative urls for RSS feeds. This is because some feed readers such as feedburner do not resolve the relative urls to the feed source domain. Relative urls also become a problem when people receive feed updates via email.

This pull request converts relative urls to absolute urls when compiling the RSS xml.

Please note that the request is against this commit:
8918706
Google Analytics now optionally supports setting _setDomainName using domain_name config value

I could not successfully get my current blog to work against the latest master of ruhoh.rb

@amanking

This comment has been minimized.

Show comment
Hide comment
@amanking

amanking Mar 13, 2014

Contributor

Closing this pull request as the commit was not against latest code. A merge-able pull request for the same issue is here: #284

Contributor

amanking commented Mar 13, 2014

Closing this pull request as the commit was not against latest code. A merge-able pull request for the same issue is here: #284

@amanking amanking closed this Mar 13, 2014

@amanking amanking deleted the amanking:rss_with_absolute_urls branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment